Re: Issue #512, Multiple forms with captcha #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request victorjonsson#501 from FuzzyBS/master
$form.context.validationConfig not set for additional forms when callback runs on first form setup.
In addition to previous commit, I realized that the Google validation callback needed to identify which form so it wouldn't mark both forms, so I created an array of callback functions each with a reference to a form ID (which is created if not already present). Fingers crossed this won't blow anything up! For @jeesus to test with.
fixed jshint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've gotten the problem taken care of, but I haven't tested yet. @jeesus please test for me if you would be so kind.
Issues all regarded callback contexts. @victorjonsson we should consider replacing this one use of$.context because it's deprecated and has been removed in jQuery v.3.0. I think $ .get(0) will provide the same thing?